Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(labels): update max labels #7294

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Mierenga
Copy link
Contributor

Most APIs are being updated to allow for 50 labels. The UI also needs to be updated to reflect this change, but the API support is there.

Preparing this PR so it can be merged when deemed appropriate by the product/docs teams

Description

Testing instructions

Preview link:

Checklist

Most APIs are being updated to allow for 50 labels. The UI also needs to be updated to reflect this change, but the API support is there.

Preparing this PR so it can be merged when deemed appropriate by the product/docs teams
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit c1361a2
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/662813acd74ca000086109f6
😎 Deploy Preview https://deploy-preview-7294--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 94 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mierenga Mierenga added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Apr 23, 2024
@mheap
Copy link
Member

mheap commented May 7, 2024

@Mierenga Is this ready to review?

@Mierenga
Copy link
Contributor Author

Mierenga commented May 7, 2024

@Mierenga Is this ready to review?

The UI is not yet updated to allow 50, we should probably wait to update the docs until that is done. TDX-4122 is tracking the progress for API products.

@Mierenga
Copy link
Contributor Author

The UI has been updated to accept 50 labels for API products and API product versions. Portals labels will be 50 upon release of multi-portal. Control Plane labels are still at 5 in the UI, but accept up to 50 in the API.

@Guaris
Copy link
Contributor

Guaris commented Jun 17, 2024

@Mierenga is this ready to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants